Repository navigation
Require authorization for legacy APIs - #825
Merged
vincent-olivert-riera merged 2 commits intoNov 13, 2026
Merged
vincent-olivert-riera merged 2 commits into
vincent-olivert-riera merged 2 commits into
Conversation
hoangpn
force-pushed
the
feature/require_authorization_for_legacy_apis
branch
3 times, most recently
from
November 12, 2026 05:47
80d581e to
8523724
Compare
vincent-olivert-riera
requested changes
Nov 13, 2026
hoangpn
force-pushed
the
feature/require_authorization_for_legacy_apis
branch
from
November 13, 2026 05:38
8523724 to
b5b1c1c
Compare
vincent-olivert-riera
requested changes
Nov 13, 2026
Promgen's legacy APIs previously inherited from the Django View class, functioning as traditional APIs. We have now refactored them to inherit from the APIView class in the rest.py file, allowing us to leverage the features of the Django REST Framework.
Legacy APIs are used for managing Prometheus configurations, such as retrieving all targets, URLs, or reloading configurations. These actions are critical and should not be accessible to regular users. Therefore, we have implemented new permissions and now require appropriate authorization for each API to enhance their security.
hoangpn
force-pushed
the
feature/require_authorization_for_legacy_apis
branch
from
November 13, 2026 05:46
b5b1c1c to
93734f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy APIs are used for managing Prometheus configurations, such as retrieving all targets, URLs, or reloading configurations. These actions are critical and should not be accessible to regular users. Therefore, we have implemented new permissions and now require appropriate authorization for each API to enhance their security.